Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Bug Fix: Fix for rag processor throwing NPE #3097

Open
wants to merge 2 commits into
base: 2.11
Choose a base branch
from

Conversation

pyek-bot
Copy link
Contributor

@pyek-bot pyek-bot commented Oct 11, 2024

(cherry picked from commit 8b5b38e)

Description

Backporting RAG NPE fix to 2.11

Related Issues

Resolves #2983

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

pyek-bot and others added 2 commits October 11, 2024 11:08
…ch-project#3089)

* [Backport 2.17] Bug Fix: Fix for rag processor throwing NPE when optional parameters are not provided (opensearch-project#3066) (opensearch-project#3076)

(cherry picked from commit 8b5b38e)

Co-authored-by: Pavan Yekbote <[email protected]>

* fix: spotless changes

Signed-off-by: Pavan Yekbote <[email protected]>

---------

Signed-off-by: Pavan Yekbote <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Signed-off-by: Pavan Yekbote <[email protected]>
@mingshl
Copy link
Collaborator

mingshl commented Oct 18, 2024

is the field name also fixed in main and other branches? usually we tried to raise PR in main and backport to earlier versions to make sure it's the same commit all over the places.

@pyek-bot
Copy link
Contributor Author

pyek-bot commented Oct 18, 2024

is the field name also fixed in main and other branches? usually we tried to raise PR in main and backport to earlier versions to make sure it's the same commit all over the places.

Yes, this has been backported from main. While backporting to 2.11 there are merge conflicts and this PR addresses them.

PFA screenshot for merged backports, only this is pending

Screenshot 2024-10-18 at 11 10 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants