Fix: Gracefully handle error when generative_qa_parameters is not provided #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
pyek-bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
samuel-oci and
xinyual
as code owners
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dhrubo-os
reviewed
Oct 11, 2024
| @@ -126,6 +126,11 @@ public void processResponseAsync( | |||
| } | |||
|
|
|||
| GenerativeQAParameters params = GenerativeQAParamUtil.getGenerativeQAParameters(request); | |||
| if (params == null) { | |||
| throw new IllegalArgumentException( | |||
| "generative_qa_parameters not found. Please provide ext.generative_qa_parameters to proceed." | |||
There was a problem hiding this comment.
May be we can refer to this link: https://opensearch.org/docs/latest/search-plugins/conversational-search/#step-6-use-the-pipeline-for-rag
so that customer knows which values to provide in this parameter?
There was a problem hiding this comment.
makes sense, added
Zhangxunmt
previously approved these changes
Oct 11, 2024
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
DCO is failing. |
Signed-off-by: Pavan Yekbote <[email protected]>
pyek-bot
force-pushed
the
rag_gracefully_handle_missing_params
branch
from
e30acd1
to
290f89d
Compare
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
fixed |
Signed-off-by: Pavan Yekbote <[email protected]>
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
Please add backport tag upto 2.12, since RAG was introduced in this version according to this doc: https://opensearch.org/docs/latest/search-plugins/search-pipelines/rag-processor/ |
dhrubo-os
approved these changes
Oct 14, 2024
Zhangxunmt
approved these changes
Oct 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…vided (#3100) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> (cherry picked from commit 0f7481e)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.12 2.12
# Navigate to the new working tree
cd .worktrees/backport-2.12
# Create a new branch
git switch --create backport/backport-3100-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0f7481e3fba9833548074660fc79b69aef3ce527
# Push it to GitHub
git push --set-upstream origin backport/backport-3100-to-2.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.12Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…vided (#3100) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> (cherry picked from commit 0f7481e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…vided (#3100) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> (cherry picked from commit 0f7481e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…vided (#3100) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> (cherry picked from commit 0f7481e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…vided (#3100) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> (cherry picked from commit 0f7481e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…vided (#3100) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> (cherry picked from commit 0f7481e)
b4sjoo
pushed a commit
that referenced
this pull request
Oct 15, 2024
…vided (#3100) (#3111) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> (cherry picked from commit 0f7481e) Co-authored-by: Pavan Yekbote <[email protected]>
pyek-bot
added a commit
to pyek-bot/ml-commons
that referenced
this pull request
Oct 15, 2024
…vided (opensearch-project#3100) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]>
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 17, 2024
…vided (#3100) (#3106) * fix: gracefully handle error when generative_qa_parameters is not provided Signed-off-by: Pavan Yekbote <[email protected]> * fix: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * docs: adding documentation link to error message Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding UT to test null params Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> (cherry picked from commit 0f7481e) Co-authored-by: Pavan Yekbote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gracefully handles error when required parameter is not provided for a rag pipeline.
Introduced in 2.10, we can backport till there if required. Please suggest.
Related Issues
Resolves #3092
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.