-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build scripts for Notifications and Notifications Dashboards #398
Conversation
Signed-off-by: Mohammad Qureshi <[email protected]>
@peterzhuamazon Would you be able to take a look and confirm the scripts are fine and are in the right directories? For some context on the backend |
Also regarding the CI, the backend one is failing because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you have a second PR to remove default scripts from build repo.
Thanks.
Please explain these:
Thanks. |
|
We need some testing on this as we have never tried to install 2 zips for 1 component. |
PR for common-utils: opensearch-project/common-utils#156 |
|
Signed-off-by: Mohammad Qureshi [email protected]
Description
Adding build scripts for Notifications and Notifications Dashboards. Once these are merged in, we can submit another PR to the
opensearch-build
repo to remove the build scripts for Notifications there since they take precedence. Finally, after all these changes are complete, we can add Notifications to the 2.0 manifest and start testing if the build passes.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.