Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A large category of bugs in the schema is that some fields are missing. For example, the distribution filed in the response from GET / was added in #336.
We should have detected the missing field in tests. Had the info schema had
additionalProperties: false
the schema validation would have failed with "data/version must NOT have additional properties". However adding that option means that our published schema cannot be future-proof for when new fields are added.This PR dynamically injects
additionalProperties: ...
withajv-errors
that allows to custom render an error message that contains the property name that is missing.For now it only applies to any set of properties with a
required
field. Otherwise it creates some false positives on index responses with dynamic mappings.With this change:
You get all the errors:
Issues Resolved
Closes #338.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.