Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variants of indices.put_alias #434

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Jul 18, 2024

Description

Add specifications for variants of indices.put_alias

Issues Resolved

Fixes #433

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Jul 18, 2024

Changes Analysis

Commit SHA: b9b8bea
Comparing To SHA: 51cb05a

API Changes

Summary

└─┬Paths
  ├──[➕] path (7927:3)
  ├──[➕] path (191:3)
  ├─┬/{index}/_aliases/{name}
  │ ├─┬PUT
  │ │ ├──[🔀] operationId (7996:20)❌ 
  │ │ └─┬Requestbody
  │ │   └─┬application/json
  │ │     └─┬Schema
  │ │       ├──[➕] properties (22094:15)
  │ │       └──[➕] properties (22098:15)
  │ └─┬POST
  │   ├──[🔀] operationId (7973:20)❌ 
  │   └─┬Requestbody
  │     └─┬application/json
  │       └─┬Schema
  │         ├──[➕] properties (22094:15)
  │         └──[➕] properties (22098:15)
  ├─┬/_alias
  │ └──[➕] put (62:7)
  ├─┬/{index}/_alias
  │ └──[➕] put (7794:7)
  ├─┬/_alias/{name}
  │ ├──[➕] put (148:7)
  │ └──[➕] post (126:7)
  └─┬/{index}/_alias/{name}
    ├─┬PUT
    │ ├──[🔀] operationId (7905:20)❌ 
    │ └─┬Requestbody
    │   └─┬application/json
    │     └─┬Schema
    │       ├──[➕] properties (22094:15)
    │       └──[➕] properties (22098:15)
    └─┬POST
      ├──[🔀] operationId (7882:20)❌ 
      └─┬Requestbody
        └─┬application/json
          └─┬Schema
            ├──[➕] properties (22094:15)
            └──[➕] properties (22098:15)

Document Element Total Changes Breaking Changes
paths 18 4
  • BREAKING Changes: 4 out of 18
  • Modifications: 4
  • Additions: 14
  • Breaking Modifications: 4

Report

The full API changes report is available at: https:/opensearch-project/opensearch-api-specification/actions/runs/9991245606/artifacts/1714919117

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 490 (47.99 %) 7 (0.68 %)
Uncovered (%) 538 (52.69 %) 531 (52.01 %) -7 (-0.68 %)
Unknown 24 24 0

@Xtansia Xtansia marked this pull request as ready for review July 18, 2024 03:24
dblock
dblock previously approved these changes Jul 18, 2024
@dblock dblock merged commit 0453dbe into opensearch-project:main Jul 18, 2024
11 checks passed
@Xtansia Xtansia deleted the feat/put_alias_variants branch July 18, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Variations of indices.put_alias are not defined in spec
2 participants