Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correctly named folders/files. #497

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 12, 2024

Description

Some leftovers from #439.

Refresh indexes to avoid flake in observability testing. Closes #495.

With #498 CI will fail without these changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Aug 12, 2024

Changes Analysis

Commit SHA: e9e7a98
Comparing To SHA: 9eb3732

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https:/opensearch-project/opensearch-api-specification/actions/runs/10357256800/artifacts/1803192608

API Coverage

Before After Δ
Covered (%) 522 (51.13 %) 522 (51.13 %) 0 (0 %)
Uncovered (%) 499 (48.87 %) 499 (48.87 %) 0 (0 %)
Unknown 26 26 0

Copy link

github-actions bot commented Aug 12, 2024

Spec Test Coverage Analysis

Total Tested
548 208 (37.96 %)

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @dblock !

@dblock
Copy link
Member Author

dblock commented Aug 12, 2024

@nhtruong I think the intent was to name partials _core, so not to confuse with partials we don't name test files this way. But maybe we should? If you think we should rename test files to match the APIs when it's _api, let's open a new issue and add a warning/error for misnamed files.

@dblock dblock mentioned this pull request Aug 12, 2024
@dblock dblock merged commit 08bbc0e into opensearch-project:main Aug 12, 2024
17 checks passed
@dblock dblock deleted the rename branch August 12, 2024 21:10
@nhtruong
Copy link
Collaborator

nhtruong commented Aug 12, 2024

@nhtruong I think the intent was to name partials _core, so not to confuse with partials we don't name test files this way. But maybe we should? If you think we should rename test files to match the APIs when it's _api, let's open a new issue and add a warning/error for misnamed files.

_core is used as a namespace for operation groups on the root level. It's named differently from other namespace because it's omitted in the operation groups and in the clients. So instead of _core.bulk it's bulk operation group and is translated to client.bulk() on the clients instead of client._core.bulk()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Retrieve list of Observability objects is flaky
3 participants