-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add phone number analysis plugin #609
base: main
Are you sure you want to change the base?
add phone number analysis plugin #609
Conversation
Changes AnalysisCommit SHA: 6f3e2d6 API ChangesSummary
ReportThe full API changes report is available at: https:/opensearch-project/opensearch-api-specification/actions/runs/11296186194/artifacts/2046519496 API Coverage
|
Looks great! Needs CHANGELOG, and a passing build (plugin installation likely needs work, |
45270e5
to
05fcc57
Compare
this is part of opensearch-project/OpenSearch#11326. the actual implementation was done opensearch-project/OpenSearch#15915. see the commit message on the PR for further details. the new test group `analysis` has been added so that it can later be extended with all other optional language analyzers (which are currently also not covered). note that the CI currently needs to fetch the image from `opensearchstaging` as 2.18.0 hasn't been released yet. the `hub` and `ref` config can be removed once 2.18.0 has been released. Signed-off-by: Ralph Ursprung <[email protected]>
05fcc57
to
6f3e2d6
Compare
i've updated the path & added the changelog. i'm keeping this as a draft until this TODO is resolved:
acc. to @dblock the plugin should be part of the docker image (but doesn't seem to be as it tries to fetch it from the web) |
I can confirm that anlaysis-phone is not in the docker image.
|
Description
this is part of opensearch-project/OpenSearch#11326. the actual implementation was done opensearch-project/OpenSearch#15915. see the commit message on the PR for further details.
the new test group
analysis
has been added so that it can later be extended with all other optional language analyzers (which are currently also not covered).note that the CI currently needs to fetch the image from
opensearchstaging
as 2.18.0 hasn't been released yet. thehub
andref
config can be removed once 2.18.0 has been released.TODO: the plugin is not yet released => installation fails. is there a snapshot somewhere which can be used instead?
Issues Resolved
n/a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.