Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2.0.0 manifest to use 2.0 opensearch core branch #1842

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Update 2.0.0 manifest to use 2.0 opensearch core branch

Issues Resolved

Part of #1624

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Mar 29, 2022

yaml lint is not happy :(

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to single quote as we required.

Signed-off-by: Peter Zhu <[email protected]>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zelinh
Copy link
Member

zelinh commented Mar 29, 2022

system.properties_file.UnexpectedKeyValueError: Expected to have version='2.0.0.0-SNAPSHOT', but was '2.0.0.0-alpha1-SNAPSHOT'. Seems like we need to update our CI check to support qualifier :(

#1839

@peterzhuamazon
Copy link
Member Author

Same as yesterday merge this as ci does not support qualifier yet.

@peterzhuamazon peterzhuamazon merged commit a473eca into opensearch-project:main Mar 29, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-opensearch-branch branch March 29, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants