Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ml-commons to 2.0.0 manifest #1848

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

ylwu-amzn
Copy link
Contributor

Signed-off-by: Yaliang Wu [email protected]

Description

Re-add ml-commons to 2.0.0 manifest

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn requested a review from a team as a code owner March 29, 2022 23:20
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #1848 (d8e3076) into main (5a15798) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1848   +/-   ##
=========================================
  Coverage     94.53%   94.53%           
  Complexity       19       19           
=========================================
  Files           178      178           
  Lines          3625     3625           
  Branches         27       27           
=========================================
  Hits           3427     3427           
  Misses          194      194           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a15798...d8e3076. Read the comment docs.

@ylwu-amzn
Copy link
Contributor Author

check (manifests/2.0.0/opensearch-2.0.0.yml) failed

system.properties_file.UnexpectedKeyValueError: Expected to have version='2.0.0.0-SNAPSHOT', but was '2.0.0.0-alpha1-SNAPSHOT'.

@peterzhuamazon any suggestion?

@zelinh
Copy link
Member

zelinh commented Mar 29, 2022

check (manifests/2.0.0/opensearch-2.0.0.yml) failed

system.properties_file.UnexpectedKeyValueError: Expected to have version='2.0.0.0-SNAPSHOT', but was '2.0.0.0-alpha1-SNAPSHOT'.

@peterzhuamazon any suggestion?

This issue is raised here. #1839. We will need to update the CI check to support qualifier.

@ylwu-amzn
Copy link
Contributor Author

As qualifier not supported yet, I'm ok to hold this PR until it supported.

@peterzhuamazon
Copy link
Member

We will merge this for now as 2.0.0 ci does not support qualifier yet.

@peterzhuamazon peterzhuamazon merged commit 90c928c into opensearch-project:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants