Add rpm support for integTest framework #1992
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1992 +/- ##
=============================================
+ Coverage 94.41% 100.00% +5.58%
=============================================
Files 187 6 -181
Lines 3739 105 -3634
Branches 29 19 -10
=============================================
- Hits 3530 105 -3425
+ Misses 203 0 -203
+ Partials 6 0 -6 Continue to review full report at Codecov.
|
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
| @@ -12,12 +12,14 @@ | |||
|
|
|||
|
|
|||
| class Process: | |||
| def __init__(self) -> None: | |||
| def __init__(self, filename: str, distribution: str) -> None: | |||
There was a problem hiding this comment.
Process is a generic class in system, it should have nothing to do with distribution, this doesn't belong here.
| @@ -65,6 +67,10 @@ def terminate(self) -> int: | |||
| self.return_code = self.process.returncode | |||
| self.process = None | |||
|
|
|||
| if self.distribution == "rpm": | |||
There was a problem hiding this comment.
This should not live in Process.
| self.security_enabled = security_enabled | ||
| self.additional_config = additional_config | ||
| self.dependency_installer = dependency_installer | ||
|
|
||
| self.process_handler = Process() | ||
| self.process_handler = Process(self.filename, self.distribution) |
There was a problem hiding this comment.
This class is a generic Service. Subclass it into ServiceOpenSearchTar and ServiceOpenSearchRpm, ServiceOpenSearchDashboardsTar etc., and implement the differences in the child classes.
| logging.info(f"Unpacked {bundle_name}") | ||
| logging.info(f"Installing {bundle_name} in {self.install_dir}") | ||
|
|
||
| if self.distribution == "tar": |
There was a problem hiding this comment.
Subclass ServiceOpenSearch into ServiceOpenSearchTar and ``ServiceOpenSearchRpm` and implement the differences there.
Signed-off-by: Peter Zhu [email protected]
Description
Add rpm support for integTest framework
Issues Resolved
#1951
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.