Begin generating index CRUD operations #1220
Conversation
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Xtansia
force-pushed
the
feat/code-gen/indices-get
branch
from
b730726
to
6083075
Compare
Xtansia
force-pushed
the
feat/code-gen/indices-get
branch
5 times, most recently
from
92d4e70
to
d1b3104
Compare
Xtansia
changed the title
|
|
||
| ### InlineScript | ||
| - The `lang` property now accepts a `ScriptLanguage` enum instead of a `String`. |
There was a problem hiding this comment.
This too could be made backwards compatible with a patch?
| public enum ExpandWildcard implements JsonEnum { | ||
| /** | ||
| * Match any data stream or index, including hidden ones. | ||
| * Match any index, including hidden ones. |
There was a problem hiding this comment.
Could we bring back the previous comment? The note about data streams is important I think
There was a problem hiding this comment.
I'm unable to find any reference to expand wildcard in the context of data streams in any OS docs or in the source code. So I'm not sure if those comments are actually relevant to OS or if they're related to the expanded data stream APIs added in ES.
java-client/src/generated/java/org/opensearch/client/opensearch/_types/Script.java
Show resolved
Hide resolved
java-client/src/generated/java/org/opensearch/client/opensearch/_types/Script.java
Show resolved
Hide resolved
java-client/src/generated/java/org/opensearch/client/opensearch/_types/ScriptBase.java
Show resolved
Hide resolved
java-client/src/generated/java/org/opensearch/client/opensearch/_types/ScriptBase.java
Show resolved
Hide resolved
|
|
||
| @JsonpDeserializable | ||
| @Generated("org.opensearch.client.codegen.CodeGenerator") | ||
| public class RuntimeField implements PlainJsonSerializable { |
There was a problem hiding this comment.
We don't support RuntimeFields, the equivalent feature is derived fields (see please opensearch-project/OpenSearch#12281)
|
|
||
| Synthetic("synthetic"); |
There was a problem hiding this comment.
I think we don't support synthetic either
| @Nullable | ||
| private final Query filter; | ||
|
|
||
| @Nullable | ||
| private final String indexRouting; | ||
| @Nonnull |
There was a problem hiding this comment.
I believe this is not the shape of the API we support (https://www.elastic.co/guide/en/elasticsearch/reference/7.12/indices-aliases.html)
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
force-pushed
the
feat/code-gen/indices-get
branch
from
ba10e9d
to
afb4e70
Compare
Description
Begin generating indices.get, shortcutting a few of the more expansive types for property mapping and query types etc. Will make follow up PRs to generate them.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.