Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat some more @Parameter definitions to be more readable #1052

Conversation

gregschohn
Copy link
Collaborator

Description

  • Category: Cosmetic

Testing

gradle

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gregschohn gregschohn force-pushed the AestheticJCommanderParamsReformatting branch from 204dd40 to 69f74bb Compare October 8, 2024 13:06
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (823fe07) to head (d217041).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...org/opensearch/migrations/RfsMigrateDocuments.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1052   +/-   ##
=========================================
  Coverage     80.19%   80.19%           
  Complexity     2863     2863           
=========================================
  Files           383      383           
  Lines         14333    14333           
  Branches        988      988           
=========================================
  Hits          11494    11494           
  Misses         2245     2245           
  Partials        594      594           
Flag Coverage Δ
gradle-test 78.21% <0.00%> (ø)
python-test 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gregschohn gregschohn marked this pull request as ready for review October 9, 2024 03:20
@gregschohn gregschohn force-pushed the AestheticJCommanderParamsReformatting branch from 69f74bb to 4e1e5f3 Compare October 9, 2024 03:20
@gregschohn gregschohn force-pushed the AestheticJCommanderParamsReformatting branch from 4e1e5f3 to d217041 Compare October 16, 2024 04:28
@gregschohn gregschohn merged commit 1611682 into opensearch-project:main Oct 16, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants