-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Elasticsearch 6.8 support to Document Migrations #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
chelma
requested review from
AndreKurait,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
August 28, 2024 18:40
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
============================================
- Coverage 74.51% 72.08% -2.43%
+ Complexity 1961 1869 -92
============================================
Files 343 346 +3
Lines 13555 13586 +31
Branches 786 786
============================================
- Hits 10101 9794 -307
- Misses 2964 3338 +374
+ Partials 490 454 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chris Helma <[email protected]>
peternied
reviewed
Aug 28, 2024
DocumentsFromSnapshotMigration/src/test/java/com/rfs/ParallelDocumentMigrationsTest.java
Outdated
Show resolved
Hide resolved
DocumentsFromSnapshotMigration/src/test/java/com/rfs/ParallelDocumentMigrationsTest.java
Outdated
Show resolved
Hide resolved
DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java
Show resolved
Hide resolved
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
peternied
reviewed
Aug 29, 2024
DocumentsFromSnapshotMigration/src/test/java/com/rfs/EndToEndTest.java
Outdated
Show resolved
Hide resolved
DocumentsFromSnapshotMigration/src/test/java/com/rfs/EndToEndTest.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Aug 29, 2024
DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java
Show resolved
Hide resolved
Signed-off-by: Chris Helma <[email protected]>
peternied
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ES_6_8_Updates_Deletes_Native
) is currently used in our unit tests, while the other two (ES_5_6_Updates_Deletes
,ES_6_8_Updates_Deletes_Merged
) are not currently used, but will be used when we support Lucene Version hot-swapping (https://opensearch.atlassian.net/browse/MIGRATIONS-1965) and the ability to handle Indices originally created on an Elastic 5.X cluster in an Elastic 6.X source snapshot.Issues Resolved
Testing
Lots of manual testing with Docker Compose; unit testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.