-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Create writeable implementations for default value #351
Comments
|
Some draft code by @mloufra has highlighted a few key facts:
The whole purpose of the fallback is to provide backwards compatibility for an older version of the setting, so users do not have to change their config file, but a new setting name will provide the same functionality. So for example in
We need to test 3 cases:
Fixing the case 2 failure is the purpose of this issue. So the best approach for this PR is to:
|
Is your feature request related to a problem?
The
Function
class used for thedefaultValue
field inSetting
is not Writeable.What solution would you like?
Create writeable implementations for parser that implement both
Function<Settings, String>
andWriteable
interfaces for all existing setting implementations.Update
WriteableSetting
to write the defaultValue function as well as the underlying string (getRaw
).The text was updated successfully, but these errors were encountered: