-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Refector the inner classfor Setting #457
Comments
Can you add more details in this issue @mloufra? Add a link of the comment from the PR and you can also link the file here |
sure |
Good discussion to have and I'll toss in a link to a comment by @reta when TLDR: We can refactor the existing code but most of it still needs to exist, it's just a question of how to reorganize the logic and where to put it, and I somewhat prefer the existing implementation @mloufra is doing to address #349. Extended background:
So, if I were refactoring it, I'd probably make new standalone classes for each of the different |
Thanks for the detailed explanation @dbwiddis! I am inline with creating different |
Is your feature request related to a problem?
As this comment mentioned. There are too many parser class which implement
Function<Setting, ?>
andWriteable
was added inSetting.java
. Here is the one of the Writeable Parser classpublic static class FloatParser implements Function<String, Float>, Writeable
in the Setting classWhat solution would you like?
Create a separate class for these writeable parsers and store them in one place instead of
Setting.java
classThe text was updated successfully, but these errors were encountered: