Initial Commit #1
Conversation
Signed-off-by: Owais Kazi <[email protected]>
| @@ -2,3 +2,28 @@ | |||
| This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). | |||
| For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact | |||
| [email protected] with any additional questions or comments. | |||
|
|
|||
There was a problem hiding this comment.
@owaiskazi19 can you open an issue to add the following:
- Code Owners
- Maintainers.md
I've updated the branch protection rules to require a PR to merge to main.
| import java.util.Locale; | ||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| public class Netty4Utils { |
There was a problem hiding this comment.
Could you open an issue to expose few of these classes as maven artifacts for SDK to consume? (on OpenSearch) and link it to the SDK meta issue as things to do.
There was a problem hiding this comment.
| return getGenericGroup(); | ||
| } | ||
|
|
||
| // Remove HTTP calls |
There was a problem hiding this comment.
Yes, I added that comment to specify that HTTP calls are removed here from the SharedGroupFactory file present in OpenSearch.
| import static java.util.Collections.emptySet; | ||
| import static org.opensearch.common.UUIDs.randomBase64UUID; | ||
|
|
||
| public class RunPlugin { |
There was a problem hiding this comment.
Rename it to ExtensionsRunner?
No more plugins :)
|
|
||
| package transportservice; | ||
|
|
||
| import io.netty.buffer.*; |
There was a problem hiding this comment.
Please open an issue to fail our precommits when * imports are used.
take a look at OpenSearch.
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
* Refactor changes from core #1 Signed-off-by: Darshit Chanpura <[email protected]> * Fix * imports Signed-off-by: Darshit Chanpura <[email protected]> * Fixes missed refactor change Signed-off-by: Darshit Chanpura <[email protected]> * Adds import order to formatting.gradle Signed-off-by: Darshit Chanpura <[email protected]> --------- Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Owais Kazi [email protected]
Description
Added the SDK code.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.