Refactor transportservice request #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
============================================
+ Coverage 65.80% 66.00% +0.20%
- Complexity 95 96 +1
============================================
Files 25 25
Lines 465 456 -9
Branches 13 13
============================================
- Hits 306 301 -5
+ Misses 151 147 -4
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vibrantvarun
reviewed
Oct 6, 2022
vibrantvarun
approved these changes
Oct 6, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* issue opensearch-project#28 Signed-off-by: mloufra <[email protected]> * Update the lastest coomit Signed-off-by: mloufra <[email protected]> * Rename the method and fix the conflict Signed-off-by: mloufra <[email protected]> * fix merge conflict Signed-off-by: mloufra <[email protected]> * Add code coverage report Signed-off-by: mloufra <[email protected]> * Rebase the lastest commit Signed-off-by: mloufra <[email protected]> * update the lastest commit Signed-off-by: mloufra <[email protected]> * Refactor transportService request Signed-off-by: mloufra <[email protected]> * delete transportService object change Signed-off-by: mloufra <[email protected]> Signed-off-by: mloufra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a new method
sendGenericRequestWithExceptionHandlingto handle the duplicate code for transport request methodsendClusterStateRequest,sendClusterSettingsRequest,sendLocalNodeRequest.Issues Resolved
#116
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.