Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds DeleteByQuery Request for SDKRestClient #708

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

owaiskazi19
Copy link
Member

Description

Required for Delete Detector Results to query OpenSearch using HLRC.

Issues Resolved

Part of #378

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #708 (e2073c3) into main (2991b5f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #708      +/-   ##
============================================
+ Coverage     66.21%   66.26%   +0.05%     
  Complexity      301      301              
============================================
  Files            55       55              
  Lines          1243     1245       +2     
  Branches         41       41              
============================================
+ Hits            823      825       +2     
  Misses          408      408              
  Partials         12       12              
Impacted Files Coverage Δ
src/main/java/org/opensearch/sdk/SDKClient.java 89.47% <100.00%> (+0.18%) ⬆️

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (will approve after questions answered) but I'm really interested in why this request looks so different to all the others.

@dbwiddis dbwiddis merged commit b30bec4 into opensearch-project:main Apr 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 28, 2023
Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit b30bec4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Apr 28, 2023
(cherry picked from commit b30bec4)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants