Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure whitesource. #4

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 7, 2023

Description

Not sure what happened in #1, I think it was closed because of a force push to main for the initial commit.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend configuring this to use Remediate in preference to dependabot.

See https:/opensearch-project/opensearch-ai-flow-framework/pull/1/files

  "remediateSettings": {
    "workflowRules": {
      "enabled": true
    }
  }

@dblock
Copy link
Member Author

dblock commented Sep 7, 2023

I copied the contents of that .whitesource. Am I doing it right?

@dbwiddis
Copy link
Member

dbwiddis commented Sep 7, 2023

I copied the contents of that .whitesource. Am I doing it right?

Yes, I believe so.

To be clear, this is a choice of which dependency manager we use. I prefer Remediate to Dependabot so if we merge this PR we should close #5. And vice versa. See https:/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#keep-dependencies-up-to-date for a discussion of the options before we pick one.

@dbwiddis
Copy link
Member

dbwiddis commented Sep 7, 2023

Alternately it looks like for python there's another option: https://docs.safetycli.com/safety-2/

@dblock
Copy link
Member Author

dblock commented Sep 7, 2023

Alternately it looks like for python there's another option: https://docs.safetycli.com/safety-2/

I'd rather not introduce new tools unless you feel very motivated ;)

@dbwiddis
Copy link
Member

dbwiddis commented Sep 7, 2023

If you're happy with Renovate, let's merge this and close #5.

@dblock dblock merged commit 91233a5 into opensearch-project:main Sep 7, 2023
3 checks passed
@dblock dblock deleted the configure-whitesource branch September 7, 2023 18:52
@dbwiddis dbwiddis mentioned this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants