Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for mappings of custom log types & other bug fixes #505

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Aug 1, 2023

Description

fix for mappings of custom log types & other bug fixes

Issues Resolved

#447

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #505 (79d1985) into 2.x (ef64f00) will decrease coverage by 0.14%.
The diff coverage is 4.79%.

@@             Coverage Diff              @@
##                2.x     #505      +/-   ##
============================================
- Coverage     25.95%   25.82%   -0.14%     
+ Complexity      940      939       -1     
============================================
  Files           252      252              
  Lines         10686    10737      +51     
  Branches       1187     1197      +10     
============================================
- Hits           2774     2773       -1     
- Misses         7665     7716      +51     
- Partials        247      248       +1     
Files Changed Coverage Δ
...ityanalytics/action/IndexCustomLogTypeRequest.java 0.00% <0.00%> (ø)
...search/securityanalytics/mapper/MapperService.java 0.00% <0.00%> (ø)
.../transport/TransportDeleteCustomLogTypeAction.java 0.00% <0.00%> (ø)
...s/transport/TransportIndexCustomLogTypeAction.java 0.00% <0.00%> (ø)
...tics/transport/TransportListCorrelationAction.java 0.00% <0.00%> (ø)
...arch/securityanalytics/logtype/LogTypeService.java 40.29% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

@sbcd90 sbcd90 merged commit 745874d into opensearch-project:2.x Aug 2, 2023
13 of 15 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-505-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 745874da717812003151a32a92f17c0305490af6
# Push it to GitHub
git push --set-upstream origin backport/backport-505-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-505-to-main.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 745874d)
sbcd90 pushed a commit that referenced this pull request Aug 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 745874d)
sbcd90 pushed a commit that referenced this pull request Sep 1, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* [BUG] Edit details Save button should be blue opensearch-project#499

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-505-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 745874da717812003151a32a92f17c0305490af6
# Push it to GitHub
git push --set-upstream origin backport/backport-505-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-505-to-2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants