Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] Fix keywords bug incorrectly adding field value (#964) #968

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jowg-amazon
Copy link
Collaborator

Description

Manual backport of #964

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jowg-amazon jowg-amazon changed the title [Backport 2.5] fix keywords bug and add comments (#964) [Backport 2.5] Fix keywords bug incorrectly adding field value Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.96%. Comparing base (2d10915) to head (4aea86c).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.5     #968      +/-   ##
============================================
- Coverage     36.00%   35.96%   -0.05%     
+ Complexity      894      893       -1     
============================================
  Files           179      179              
  Lines          7213     7208       -5     
  Branches        870      870              
============================================
- Hits           2597     2592       -5     
  Misses         4381     4381              
  Partials        235      235              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon changed the title [Backport 2.5] Fix keywords bug incorrectly adding field value [Backport 2.5] Fix keywords bug incorrectly adding field value (#964) Apr 4, 2024
@jowg-amazon jowg-amazon merged commit c7cc8cf into opensearch-project:2.5 Apr 5, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants