Adds snapshot management cluster permissions #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1016 +/- ##
=======================================
Coverage 72.21% 72.21%
=======================================
Files 87 87
Lines 1915 1915
Branches 249 249
=======================================
Hits 1383 1383
Misses 478 478
Partials 54 54
Continue to review full report at Codecov.
|
DarshitChanpura
previously approved these changes
Jun 24, 2022
|
@downsrob Can you please re-base with main? |
Signed-off-by: Clay Downs <[email protected]>
downsrob
force-pushed
the
snapshot-management-security
branch
from
00b51c0
to
3b5c047
Compare
|
@DarshitChanpura Done! |
peternied
approved these changes
Jun 24, 2022
cliu123
approved these changes
Jun 24, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
Signed-off-by: Clay Downs <[email protected]> (cherry picked from commit ccf0e1f)
peternied
pushed a commit
that referenced
this pull request
Jun 25, 2022
Signed-off-by: Clay Downs <[email protected]> (cherry picked from commit ccf0e1f) Co-authored-by: Clay Downs <[email protected]>
spartan2015
pushed a commit
to spartan2015/security-dashboards-plugin
that referenced
this pull request
Aug 8, 2022
Signed-off-by: Clay Downs <[email protected]> Signed-off-by: Vasile Negru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Clay Downs [email protected]
Description
Adds snapshot management cluster permissions
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Why these changes are required?
The snapshot management plugin under the index management repository will be released in 2.1.
Here is the backend security PR opensearch-project/security#1897
As this feature is targeted for 2.1, this PR may need to be backported
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.