Fixes broken main build which was caused due to version mismatch #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
force-pushed
the
fix-broken-main-build
branch
from
66fedf8
to
d0075b1
Compare
|
This is a much better than the change I had pointed to the 2.0 branch |
This was referenced May 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 87 87
Lines 1906 1906
Branches 242 247 +5
=======================================
Hits 1375 1375
Misses 477 477
Partials 54 54 Continue to review full report at Codecov.
|
cliu123
reviewed
May 16, 2022
| @@ -5,6 +5,10 @@ on: [push, pull_request] | |||
| env: | |||
| TEST_BROWSER_HEADLESS: 1 | |||
| CI: 1 | |||
| OPENSEARCH_DASHBOARDS_VERSION: 2.0 | |||
| OPENSEARCH_CORE_VERSION: 2.0 | |||
| OPENSEARCH_CORE_VERSION_QUALIFIER: ${{OPENSEARCH_CORE_VERSION}}.0 | |||
There was a problem hiding this comment.
Integration tests fail because these variables are not declared successfully. You can reference to here and declare the env variables in the same way to make them available.
DarshitChanpura
force-pushed
the
fix-broken-main-build
branch
from
786fb96
to
f2aeaea
Compare
cliu123
reviewed
May 16, 2022
| @@ -5,6 +5,8 @@ on: [push, pull_request] | |||
| env: | |||
| TEST_BROWSER_HEADLESS: 1 | |||
| CI: 1 | |||
| OPENSEARCH_DASHBOARDS_VERSION: 2.0 | |||
| OPENSEARCH_CORE_VERSION: 2.0 | |||
There was a problem hiding this comment.
This 2 variables need to be defined with echo... >> $GITHUB_ENV too to be available for reference.
DarshitChanpura
force-pushed
the
fix-broken-main-build
branch
17 times, most recently
from
c5c89bf
to
0ba1aad
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
fix-broken-main-build
branch
9 times, most recently
from
3498dea
to
4dddfa7
Compare
cliu123
previously approved these changes
May 16, 2022
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
fix-broken-main-build
branch
from
4dddfa7
to
80f90d6
Compare
cliu123
approved these changes
May 16, 2022
peterzhuamazon
approved these changes
May 16, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 16, 2022
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 426ec61)
cliu123
pushed a commit
to cliu123/security-dashboards-plugin
that referenced
this pull request
May 17, 2022
…nsearch-project#989) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 426ec61) Signed-off-by: cliu123 <[email protected]>
peternied
pushed a commit
that referenced
this pull request
May 17, 2022
… (#995) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 426ec61) Signed-off-by: cliu123 <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken main build
Issues Resolved
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.