-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Create extension point to be able to register security settings into extensions.yml
#2746
Comments
[Triaging] @peternied to take a look at this, related to the Extensions project. |
I'm tackling making these items available, but I won't reuse the 'Settings' interface, we will use the extensions object so there is a strong interface between core <-> security plugin |
Coming from: #2749 (comment) The terminology confused me, settings in OpenSearch are a way to configure at bootstrap/runtime and is driven by Looks like we'd want to register few settings from Security plugin for extensions. [1] https:/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/common/settings/SettingsModule.java |
Removed myself since it looks like @cwperks might want to take point with the implementation |
Thank you @peternied, I will look into it. |
@peternied I created a PR in core that shows an implementation of how the IdentityPlugin can define additional settings in |
@saratvemulapalli I opened up a PR in core that demonstrates how the IdentityPlugin can extend the settings in |
Closing this issue as the PR in core was merged: opensearch-project/OpenSearch#7526 |
The security plugin uses the ActionPlugin.getSettings() extension point to add security settings to
opensearch.yml
. For extensions, there are multiple instances where the security plugin will need to register security settings for an extension.Examples include:
extensions/extensions.yml
setting to enable backward compatible plugin mode for extensions #2616extension_dns
list inextensions.yml
file #2730There needs to be an extension point that the security plugin can hook into to add settings that would be placed into
extensions.yml
so that the security plugin can read in the settings.The text was updated successfully, but these errors were encountered: