Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace opensearch class names with opendistro class names during serialization and restore them back during deserialization (#1278)" #1691

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Mar 21, 2022

Description

This PR being reverted is one of the things that would be broken by JDK17. JDK17 support got postponed to 2.0 because we'd like to keep the commits like this one being reverted to support rolling upgrade from ODFE/ES versions to OpenSearch 1.x. But in 2.0, we can revert them to unblock JDK17 since we won't need to support rolling upgrade directly from ODFE/ES versions to OpenSearch 2.0. The upgrade path ODFE -> OpenSearch 1.x -> OpenSearch 2.0 will still be retained.

This reverts commit 4abbafc.

Signed-off-by: cliu123 [email protected]

Issues Resolved

#1653

Testing

UT

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ring serialization and restore them back during deserialization (opensearch-project#1278)"

This reverts commit 4abbafc.

Signed-off-by: cliu123 <[email protected]>
@cliu123 cliu123 requested a review from a team March 21, 2022 21:03
@cliu123 cliu123 changed the title Revert "Replace opensearch class names with opendistro class names during serialization and restore them back during deserialization (#1278) Revert "Replace opensearch class names with opendistro class names during serialization and restore them back during deserialization (#1278)" Mar 21, 2022
@peternied
Copy link
Member

@cliu123 Could you add a little detail for why we are reverting this change? At first glance, it seems like we are loosing a level of backward compatibility

@cliu123
Copy link
Member Author

cliu123 commented Mar 21, 2022

@cliu123 Could you add a little detail for why we are reverting this change? At first glance, it seems like we are loosing a level of backward compatibility

Sure. This PR being reverted is one of the things that would be broken by JDK17. JDK17 support got postponed to 2.0 because we'd like to keep the commits like this one being reverted to support rolling upgrade from ODFE/ES versions to OpenSearch 1.x. But in 2.0, we can revert them to unblock JDK17 since we won't need to support rolling upgrade directly from ODFE/ES versions to OpenSearch 2.0. The upgrade path ODFE -> OpenSearch 1.x -> OpenSearch 2.0 will still be retained.

@peternied
Copy link
Member

Thanks for the details, I'm going to update the description of this PR to include those details and tag it 2.0.0

@cliu123 cliu123 merged commit fa9cd5b into opensearch-project:main Mar 22, 2022
@cliu123 cliu123 deleted the revert_class_name_patch_change_to_support_jdk17 branch March 22, 2022 16:31
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…ring serialization and restore them back during deserialization (opensearch-project#1278)" (opensearch-project#1691)

This reverts commit 4abbafc.

Signed-off-by: cliu123 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants