HttpStatus is only imported from org.apache.http
#3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhas Kurapati <[email protected]>
prabhask5
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
|
@DarshitChanpura @peternied In this PR I only refactored the HttpStatus import, please let me know if there's areas that should not be refactored/changed to something else. Based on @peternied 's advice in the previous PR I'm going to have this PR only for HttpStatus refactors, and when it's merged I'll play around with the Header refactors in another PR and find a way to do so without the errors I've been getting. Thanks! |
prabhask5
changed the title
org.apache.hc.core5.httporg.apache.hc.core5.http - HttpStatus Refactor Only
Signed-off-by: Prabhas Kurapati <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3741 +/- ##
==========================================
- Coverage 65.23% 65.20% -0.03%
==========================================
Files 297 297
Lines 21129 21129
Branches 3451 3451
==========================================
- Hits 13783 13778 -5
- Misses 5647 5651 +4
- Partials 1699 1700 +1 |
peternied
approved these changes
Nov 20, 2023
willyborankin
approved these changes
Nov 20, 2023
peternied
changed the title
org.apache.hc.core5.http - HttpStatus Refactor Onlyorg.apache.http
prabhask5
added a commit
to prabhask5/opensearch-security
that referenced
this pull request
Jan 11, 2024
…t#3741) Signed-off-by: Prabhas Kurapati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accounts for refactor of HttpStatus classes from hc.core5.http to just http by adding checkstyle test, and manually refactoring all current occurrences of the illegal import. Additionally updated spotlessApply to make the refactor automatic on future cases of illegal import.
Bug fix/refactor
org.apache.hc.core5.http#3581Ideally nothing.
Issues Resolved
org.apache.hc.core5.http#3581Is this a backport? If so, please add backport PR # and/or commits #
No.
Testing
Tests have been modified and should work before merging.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.