Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test SlowIntegrationTests.testDelayInSecurityIndexInitialization #3763

Merged
merged 11 commits into from
Dec 14, 2023
Merged

Fix flaky test SlowIntegrationTests.testDelayInSecurityIndexInitialization #3763

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0467215
Fix flaky test SlowIntegrationTests.testDelayInSecurityIndexInitializ…
cwperks Nov 22, 2023
4bcb7c7
Add repeat rule
cwperks Dec 5, 2023
3769d2a
Merge branch 'main' into slow-integ-tests
cwperks Dec 5, 2023
ef211b4
Remove repeat annotation
cwperks Dec 7, 2023
95414ef
Remove RepeatRule
cwperks Dec 7, 2023
62cd035
Merge branch 'main' into slow-integ-tests
cwperks Dec 12, 2023
fd18c24
Add imports
cwperks Dec 12, 2023
91321d9
Remove Thread.sleep
cwperks Dec 12, 2023
77fd8f0
Address code review comments
cwperks Dec 12, 2023
2a79ca6
Update DEVELOPER_GUIDE
cwperks Dec 12, 2023
34da97b
Small update
cwperks Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/test/java/org/opensearch/security/SlowIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.opensearch.action.admin.cluster.health.ClusterHealthRequest;
import org.opensearch.action.admin.cluster.node.info.NodesInfoRequest;
import org.opensearch.action.admin.cluster.settings.ClusterUpdateSettingsRequest;
import org.opensearch.action.admin.indices.create.CreateIndexRequest;
import org.opensearch.cluster.health.ClusterHealthStatus;
import org.opensearch.common.settings.Settings;
import org.opensearch.common.unit.TimeValue;
Expand Down Expand Up @@ -225,10 +226,14 @@ public void testDelayInSecurityIndexInitialization() throws Exception {
.build();
try {
setup(Settings.EMPTY, null, settings, false);
cwperks marked this conversation as resolved.
Show resolved Hide resolved
clusterHelper.nodeClient()
.admin()
.indices()
.create(new CreateIndexRequest("test-index").timeout(TimeValue.timeValueSeconds(10)))
.actionGet();
clusterHelper.waitForCluster(ClusterHealthStatus.GREEN, TimeValue.timeValueSeconds(5), ClusterConfiguration.DEFAULT.getNodes());
Assert.fail("Expected IOException here due to red cluster state");
cwperks marked this conversation as resolved.
Show resolved Hide resolved
} catch (IOException e) {
// Index request has a default timeout of 1 minute, adding buffer between nodes initialization and cluster health check
Thread.sleep(1000 * 80);
// Ideally, we would want to remove this cluster setting, but default settings cannot be removed. So overriding with a reserved
// IP address
clusterHelper.nodeClient()
Expand Down
Loading