Add Nils Bandener (Github: nibix) as a maintainer

[cwperks]

I have nominated, and maintainers have agreed to add Nils Bandener (@nibix) as a co-maintainer, who has kindly accepted.

Nils has made many valuable contributions and given insight into the OpenSearch Security repo over the last few years.

Notable code contributions from Nils include:

• New integrationTest framework: New test framework #1967
• New algorithm for resolving action groups: New algorithm for resolving action groups #4448
• Separated DLS/FLS privilege evaluation from action privilege evaluation: Separated DLS/FLS privilege evaluation from action privilege evaluation #4490
• Remove special handling for do_not_fail_on_forbidden on cluster actions: Remove special handling for do_not_fail_on_forbidden on cluster actions #4486

Nils has engaged in maintenance of the code base like fixing flaky tests and bug fixes as well. Here are some examples:

• Fixed READ_ACTIONS required by TermsAggregationEvaluator: Fixed READ_ACTIONS required by TermsAggregationEvaluator #4582
• Fixed flaky BWC test: Fixed flaky BWC test. #4446
• Fixed test failures in FlsAndFieldMaskingTests: Fixed test failures in FlsAndFieldMaskingTests #4548

See all code contributions (Open + Closed) from Nils here: https:/opensearch-project/security/pulls?q=is%3Apr+author%3Anibix

Nils has also contributed valuable insight on many occasions including submission of 5 RFCs:

• See issues submitted by Nils here: https:/opensearch-project/security/issues?q=is%3Aissue+author%3Anibix

Nils regularly contributes to conversation on Pull Requests, RFCs and other issues:

• Insightful comment from Nils on recent RFC: [Proposal] Resource Permissions and Sharing #4500 (comment)
• Example where Nils contributed valuable insight on a PR: Adds a check to skip serialization-deserialization if request is for same node #2765
• Example where Nils contributed valuable insight in an issue: OpenSSL engine support is broken #2195 (comment)

See all PRs where Nils has engaged as a commenter: https:/opensearch-project/security/pulls?q=is%3Apr+commenter%3Anibix

See all issues where Nils has engaged as a commenter: https:/opensearch-project/security/issues?q=is%3Aissue+commenter%3Anibix

Additionally, Nils is active in the community and has given a talk at OpenSearch Con EU: https://opensearch.org/community/members/nbendener.html

[peternied]

@nibix well deserved!

[peternied]

@opensearch-project/admin Could we have the repo permissions updated to include @nibix as a new maintainer?

[opensearch-trigger-bot]

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/security/backport-1.3
# Create a new branch
git switch --create backport/backport-4672-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7ef02e421aa8eb634654d2a7ed5c2ec7a1c4b65
# Push it to GitHub
git push --set-upstream origin backport/backport-4672-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-4672-to-1.3.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4672-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7ef02e421aa8eb634654d2a7ed5c2ec7a1c4b65
# Push it to GitHub
git push --set-upstream origin backport/backport-4672-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4672-to-2.x.

[opensearch-trigger-bot]

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-1.x
# Create a new branch
git switch --create backport/backport-4672-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7ef02e421aa8eb634654d2a7ed5c2ec7a1c4b65
# Push it to GitHub
git push --set-upstream origin backport/backport-4672-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-4672-to-1.x.

[cwperks]

@opensearch-project/admin Could we have the repo permissions updated to include @nibix as a new maintainer?

Updated permissions for @nibix

[peternied]

@cwperks Could you take care of the backports conflicts?

[cwperks]

Sure.

[nibix]

Thank you so much. Feeling honored! 😊

[stephen-crawford]

Welcome aboard @nibix! No takesy-backsies