Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more orderless parameters for KEMANS and AD commands #462

Closed
jackiehanyang opened this issue Mar 4, 2022 · 0 comments
Closed

Support more orderless parameters for KEMANS and AD commands #462

jackiehanyang opened this issue Mar 4, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jackiehanyang
Copy link
Contributor

jackiehanyang commented Mar 4, 2022

Is your feature request related to a problem? Please describe.
Currently the KMEANS command works in this format (version 1.3):
{ "query": "source=xxx | fields xxx | kmeans 2"}

We can improve it by allowing more parameters and define a name to each parameter so parameters can be orderless. For example, the previous command now works in this format:
{ "query": "source=xxx | fields xxx | kmeans centroids=2"}

Describe the solution you'd like
Changing the Antlr parsing tree so it can takes more orderless parameters.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jackiehanyang jackiehanyang added the enhancement New feature or request label Mar 4, 2022
@jackiehanyang jackiehanyang changed the title Improve KEMANS command Support more arguments for KEMANS and AD commands Mar 8, 2022
@jackiehanyang jackiehanyang changed the title Support more arguments for KEMANS and AD commands Support more orderless parameters for KEMANS and AD commands May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant