Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ODBC version to 1.4 for release #542

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

Driver versions are independent of core and plugin versions. Since there are no breaking change after ODBC 1.3, releasing it as version 1.4.0.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner April 7, 2022 16:57
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are following semvar. Totally agree we should not bump major version if there is no breaking change.
Questions?

  1. How does customer aware of the relationship between SQL and ODBC driver?

@joshuali925
Copy link
Member Author

joshuali925 commented Apr 7, 2022

I think we are following semvar. Totally agree we should not bump major version if there is no breaking change. Questions?

  1. How does customer aware of the relationship between SQL and ODBC driver?

ODBC driver tries to be backwards compatible, even with ODFE SQL, so right now users can mix ODBC >= 1.0 with different SQL versions.

When there is a breaking change, ODBC will do a new release (2.0) and indicate it's no longer compatible with SQL less than a specific version. and when it happens we can probably include a version compatible matrix in readme

@joshuali925 joshuali925 merged commit 9b43d3f into opensearch-project:main Apr 7, 2022
vamsi-amazon pushed a commit that referenced this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants