Removed ES reference from build.gradle #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
commented
Apr 15, 2022
| @@ -131,7 +118,7 @@ afterEvaluate { | |||
| fileMode 0644 | |||
| dirMode 0755 | |||
|
|
|||
| requires('elasticsearch-oss', versions.elasticsearch, EQUAL) | |||
There was a problem hiding this comment.
Not sure where the versions.elasticsearch is defined and if it all it's being used. It'll be great if someone can point the reference.
owaiskazi19
force-pushed
the
remove-es-reference
branch
from
d17a09a
to
7a4b9c2
Compare
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
remove-es-reference
branch
from
7a4b9c2
to
f71a1df
Compare
Codecov Report
@@ Coverage Diff @@
## main #562 +/- ##
=========================================
Coverage 94.59% 94.59%
Complexity 2742 2742
=========================================
Files 276 276
Lines 7454 7454
Branches 550 550
=========================================
Hits 7051 7051
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vamsi-amazon
approved these changes
Apr 18, 2022
vamsi-amazon
pushed a commit
that referenced
this pull request
Apr 19, 2022
Signed-off-by: Owais Kazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Owais Kazi [email protected]
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.