Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented version to 1.3.4. #681

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Jul 7, 2022

Signed-off-by: Zelin Hao [email protected]

Description

Increment version to 1.3.4

Issues Resolved

Part of opensearch-project/opensearch-build#2205

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner July 7, 2022 22:01
@joshuali925
Copy link
Member

just reran CI, looks like opensearch-ml is still not ready

   > Could not find org.opensearch:opensearch-ml-client:1.3.4.0-SNAPSHOT.
     Searched in the following locations:

@zelinh
Copy link
Member Author

zelinh commented Jul 11, 2022

We will need to get this one in first to unblock this PR.

joshuali925
joshuali925 previously approved these changes Jul 13, 2022
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving first, might need some time for CI to be able to pass

kavithacm
kavithacm previously approved these changes Jul 13, 2022
@kavithacm
Copy link
Collaborator

CI is failing, re-running the failed jobs

@zelinh
Copy link
Member Author

zelinh commented Jul 13, 2022

We are re-triggering the build with ml-commons artifacts in; should be having it after.

Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 dismissed stale reviews from kavithacm and themself via 9194eed July 13, 2022 01:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #681 (9194eed) into 1.3 (0b5fa2b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.3     #681   +/-   ##
=========================================
  Coverage     95.25%   95.25%           
  Complexity     2746     2746           
=========================================
  Files           276      276           
  Lines          7416     7416           
  Branches        545      546    +1     
=========================================
  Hits           7064     7064           
  Misses          298      298           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5fa2b...9194eed. Read the comment docs.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if my approval counts since i pushed changes

might be easier if version bumps of dependent plugins are prioritized so we get more time to fix those errors

@kavithacm kavithacm merged commit f24de26 into opensearch-project:1.3 Jul 13, 2022
ps48 added a commit that referenced this pull request Jul 28, 2022
* Disable flaky test in JdbcTestIT. (#475)

Signed-off-by: penghuo <[email protected]>

* Update dependency opensearch-ml-client group name (#477)

Signed-off-by: jackieyanghan <[email protected]>

* Collected fixes related to bugs #280, #302, #783, #696 and 317 all together. (#479)

Signed-off-by: Yury Fridlyand <[email protected]>

* Add JDK 8 to CI Matrix  (#483) (#484)

* fixed references in java 8 and added to ci matrix
* filter test that fails due to jdk 8 bug
* use different degree to radian conversion for difference in jdk
* skip date time format tests that cause error due to jdk bug
* only disable DateTime unit test on Java 8

Bypassing failed DCO check

Signed-off-by: David Cui <[email protected]>
(cherry picked from commit b6fccbd)

Co-authored-by: David Cui <[email protected]>

* Add parse docs to PPL commands index (#486) (#487)

Signed-off-by: Joshua Li <[email protected]>

* Add 1.3.0 release notes (#492)

Signed-off-by: Eugene Lee <[email protected]>

* Add Kmeans and AD command documentation (#493) (#497)

Signed-off-by: jackieyanghan <[email protected]>
(cherry picked from commit ee4bce0)

* Bump version to 1.3.1

Signed-off-by: Sayali Gaikawad <[email protected]>

* Bump ml

Signed-off-by: Sayali Gaikawad <[email protected]>

* Add new zip

Signed-off-by: Sayali Gaikawad <[email protected]>

* Updated release drafter

Signed-off-by: Sayali Gaikawad <[email protected]>

* Remove checked-in ml-commons dependency (#529)

Signed-off-by: jackieyanghan <[email protected]>

* Bump workbench to 1.3.1 (#540)

Signed-off-by: Joshua Li <[email protected]>

* Bug Fix, return default ID when log4j ThreadContext is empty (#538) (#539) (#543)

Signed-off-by: penghuo <[email protected]>
(cherry picked from commit 54b7257)

* Incremented version to 1.3.2. (#593)

Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Joshua Li <[email protected]>

Co-authored-by: Joshua Li <[email protected]>

* Version bump 1.3.3

Signed-off-by: pgodithi <[email protected]>

* [1.3] Bump spring-beans to 5.2.20 (#632)

Signed-off-by: Joshua Li <[email protected]>

* Version bump 1.3.3

Signed-off-by: pgodithi <[email protected]>

* Incremented version to 1.3.4. (#681)

* Incremented version to 1.3.4.

Signed-off-by: Zelin Hao <[email protected]>

* bump jackson to 2.13.2

Signed-off-by: Joshua Li <[email protected]>

Co-authored-by: Joshua Li <[email protected]>

Co-authored-by: Peng Huo <[email protected]>
Co-authored-by: Jackie Han <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: David Cui <[email protected]>
Co-authored-by: Eugene Lee <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Zelin Hao <[email protected]>
Co-authored-by: pgodithi <[email protected]>
Co-authored-by: Anirudha (Ani) Jadhav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants