Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] Add Istio inject label (#8205) #884

Conversation

matzew
Copy link
Member

@matzew matzew commented Sep 27, 2024

backport of 8205 to ours

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@openshift-ci openshift-ci bot requested review from aliok and creydr September 27, 2024 05:10
Copy link

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 27, 2024

@matzew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-reconciler-aws-416 fcb4cde link true /test 416-test-reconciler-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew please rerun make generate-release

@matzew
Copy link
Member Author

matzew commented Sep 30, 2024

@pierDipi running make generate-release on my branch seems to ignore these patches:
https:/openshift-knative/eventing/blob/release-v1.15/openshift/release/generate-release.sh#L15-L16

it gets reverted. 🤷‍♂️

@pierDipi
Copy link
Member

pierDipi commented Oct 8, 2024

I'll merge and get the bot to do it

@pierDipi pierDipi merged commit 6dd3ae3 into openshift-knative:release-v1.15 Oct 8, 2024
35 of 63 checks passed
@pierDipi
Copy link
Member

pierDipi commented Oct 8, 2024

@pierDipi
Copy link
Member

pierDipi commented Oct 8, 2024

#894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants