Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2749: testutils: resourcebuilder: add CAPI + CAPA resources #333

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

damdo
Copy link
Member

@damdo damdo commented Oct 17, 2024

Extend the resourcebuilder to include some cluster-api core resources:

  • Machine
  • MachineSet
  • Cluster

And cluster-api-provider-aws resources:

  • AWSMachineTemplate
  • AWSMachine
  • AWSCluster

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2024

@damdo: This pull request references OCPCLOUD-2749 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Extend the resourcebuilder to include some cluster-api core resources:

  • Machine
  • MachineSet
  • Cluster

And a cluster-api-provider-aws resource:

  • AWSMachineTemplate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from damdo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo damdo force-pushed the testutils-resourcebuilder-capi branch 2 times, most recently from d4c4b23 to 2e95226 Compare October 18, 2024 15:09
@damdo damdo marked this pull request as ready for review October 18, 2024 16:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@damdo damdo changed the title OCPCLOUD-2749: testutils: resourcebuilder: add cluster-api resources OCPCLOUD-2749: testutils: resourcebuilder: add CAPI + CAPA resources Oct 18, 2024
@damdo
Copy link
Member Author

damdo commented Oct 18, 2024

/assign @nrb @JoelSpeed

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2024

@damdo: This pull request references OCPCLOUD-2749 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Extend the resourcebuilder to include some cluster-api core resources:

  • Machine
  • MachineSet
  • Cluster

And a cluster-api-provider-aws resource:

  • AWSMachineTemplate
  • AWSMachine
  • AWSCluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2024

@damdo: This pull request references OCPCLOUD-2749 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Extend the resourcebuilder to include some cluster-api core resources:

  • Machine
  • MachineSet
  • Cluster

And cluster-api-provider-aws resources:

  • AWSMachineTemplate
  • AWSMachine
  • AWSCluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo damdo force-pushed the testutils-resourcebuilder-capi branch from 2e95226 to 37beb3d Compare October 19, 2024 07:22
Copy link
Contributor

openshift-ci bot commented Oct 19, 2024

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants