Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-6380: Bump k8s 1.26, go 1.19 #164

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

damdo
Copy link
Member

@damdo damdo commented Jan 27, 2023

Bumps the k8s version to 1.26 and go 1.19.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 27, 2023
@damdo
Copy link
Member Author

damdo commented Jan 30, 2023

/test unit

1 similar comment
@damdo
Copy link
Member Author

damdo commented Jan 30, 2023

/test unit

@damdo
Copy link
Member Author

damdo commented Feb 1, 2023

/retest

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Comment on lines +5 to +8
// github.com/onsi/ginkgo/v2 v2.5.0+ has a race condition bug
// see: https:/onsi/ginkgo/issues/1134
// Pinning this to a prior version until that's resolved
replace github.com/onsi/ginkgo/v2 => github.com/onsi/ginkgo/v2 v2.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, very useful

@damdo damdo changed the title Bump k8s 1.26, go 1.19 OCPCLOUD-1869: Bump k8s 1.26, go 1.19 Feb 8, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2023

@damdo: This pull request references OCPCLOUD-1869 which is a valid jira issue.

In response to this:

Bumps the k8s version to 1.26 and go 1.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da1ecda and 2 for PR HEAD a966200 in total

@damdo
Copy link
Member Author

damdo commented Feb 8, 2023

/retest

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-ovn

The tests passed, but deprovision failed due to infrastructure issues I believe, no need to retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

The tests passed, but deprovision failed due to infrastructure issues I believe, no need to retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member Author

damdo commented Feb 8, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2a90938 into openshift:main Feb 8, 2023
@damdo damdo changed the title OCPCLOUD-1869: Bump k8s 1.26, go 1.19 OCPBUGS-6380: Bump k8s 1.26, go 1.19 Feb 8, 2023
@openshift-ci-robot
Copy link

@damdo: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6380 has been moved to the MODIFIED state.

In response to this:

Bumps the k8s version to 1.26 and go 1.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants