Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masthead username toggle does not uses fullName #13744

Open
ShaharIlany opened this issue Apr 9, 2024 · 11 comments
Open

Masthead username toggle does not uses fullName #13744

ShaharIlany opened this issue Apr 9, 2024 · 11 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@ShaharIlany
Copy link

Just updated to 4.15.0-0.okd-2024-03-10-010116

The text at the top left corner of the console used to be my full name, now it just displays my username (my email) instead.

Is this intended behavior?

image
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2024
@spadgett
Copy link
Member

Hi, is this is an intentional change. We can't always rely on having access to the user's full name with external OIDC providers, so we've changed the masthead to show the user's email address. Please let us know if this causes an issue.

/close

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

@spadgett: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

Hi, is this is an intentional change. We can't always rely on having access to the user's full name with external OIDC providers, so we've changed the masthead to show the user's email address. Please let us know if this causes an issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaharIlany
Copy link
Author

It can be nice to have the ability to choose what field will be shown there.
As an alternative, email can be shown as a fallback only if the full name is undefined/null

I work at a company where most of the user's emails are just meanless numbers and letters before the domain part, which says nothing to the user.

@spadgett

@spadgett
Copy link
Member

Let me reopen the issue, and we'll consider adding it back. Thanks for the feedback!

@jhadvig @alimobrem FYI

@spadgett spadgett reopened this Jul 15, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 15, 2024
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Sep 14, 2024
Copy link
Contributor

openshift-ci bot commented Sep 14, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logonoff
Copy link
Member

/remove-lifecycle rotten
/reopen

Still an issue

@openshift-ci openshift-ci bot reopened this Sep 23, 2024
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@logonoff: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Still an issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 23, 2024
@logonoff
Copy link
Member

/lifecycle frozen

@openshift-ci openshift-ci bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants