Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-10562: re-enable operator-uninstall.spec.ts but disable the failing test #12738

Closed
wants to merge 1 commit into from
Closed

OCPBUGS-10562: re-enable operator-uninstall.spec.ts but disable the failing test #12738

wants to merge 1 commit into from

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 18, 2023 •
edited
Loading

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 18, 2023
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-10562, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yanpzhan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

… Subscription

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2023
@openshift-ci openshift-ci bot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2023
@rhamilto
Copy link
Member Author

/retest

@rhamilto rhamilto force-pushed the OCPBUGS-10562 branch 2 times, most recently from 2c7a651 to 29d1d88 Compare May 8, 2023 11:53
@rhamilto
Copy link
Member Author

rhamilto commented May 8, 2023

/retest

2 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented May 8, 2023

/retest

@rhamilto
Copy link
Member Author

rhamilto commented May 8, 2023

/retest

@rhamilto
Copy link
Member Author

/retest

@rhamilto rhamilto force-pushed the OCPBUGS-10562 branch 4 times, most recently from c818ce0 to a5c000c Compare July 21, 2023 20:37
@rhamilto rhamilto changed the title [WIP] OCPBUGS-10562: re-enable operator-uninstall.spec.ts and add check for… [WIP] OCPBUGS-10562: re-enable operator-uninstall.spec.ts and improve other tests Jul 21, 2023
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-10562, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yanpzhan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto
Copy link
Member Author

/retest

@rhamilto rhamilto force-pushed the OCPBUGS-10562 branch 3 times, most recently from d40c86d to 125e665 Compare July 25, 2023 01:03
@rhamilto
Copy link
Member Author

/retest

@rhamilto
Copy link
Member Author

/retest

1 similar comment
@rhamilto
Copy link
Member Author

/retest

@rhamilto rhamilto changed the title [WIP] OCPBUGS-10562: re-enable operator-uninstall.spec.ts and improve other tests OCPBUGS-10562: re-enable operator-uninstall.spec.ts and improve other tests Jul 31, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
jhadvig
jhadvig approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

...tend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/descriptors.spec.ts Outdated
cy.visit(
`/k8s/ns/${testName}/operators.coreos.com~v1alpha1~ClusterServiceVersion/${testCSV.metadata.name}/${testCRD.spec.group}~${testCRD.spec.versions[0].name}~${testCRD.spec.names.kind}`,
);
// enure the app is loaded before visting the form
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
// enure the app is loaded before visting the form
// ensure the app is loaded before visting the form

...tend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/descriptors.spec.ts Outdated
);
// enure the app is loaded before visting the form
cy.visit('/');
nav.sidenav.switcher.changePerspectiveTo('Administrator');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just to ensure the the context stays in the Admin perspective ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. We'd had flakes in the past where the perspective was wrong and the tests of course fail when that happens.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 80bf966 and 2 for PR HEAD a76f7d1 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0d6bda1 and 1 for PR HEAD a76f7d1 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c033f3a and 0 for PR HEAD a76f7d1 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision a76f7d1 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@rhamilto
Copy link
Member Author

/retest

@rhamilto
Copy link
Member Author

I think we should wait for the Cypress upgrade before re-enabling this test as it is continuing to flake.

@rhamilto rhamilto changed the title OCPBUGS-10562: re-enable operator-uninstall.spec.ts and improve other tests [WIP] OCPBUGS-10562: re-enable operator-uninstall.spec.ts and improve other tests Aug 24, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

New changes are detected. LGTM label has been removed.

@rhamilto rhamilto changed the title [WIP] OCPBUGS-10562: re-enable operator-uninstall.spec.ts and improve other tests [WIP] OCPBUGS-10562: re-enable operator-uninstall.spec.ts but disable the failing test Aug 24, 2023
@rhamilto rhamilto changed the title [WIP] OCPBUGS-10562: re-enable operator-uninstall.spec.ts but disable the failing test OCPBUGS-10562: re-enable operator-uninstall.spec.ts but disable the failing test Aug 24, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2023
@rhamilto
Copy link
Member Author

I think we should wait for the Cypress upgrade before re-enabling this test as it is continuing to flake.

On second thought, I think we should re-enable the suite, but disable the failing test for the time being and re-enable the failing test in #13070.

@rhamilto
Copy link
Member Author

I think we should wait for the Cypress upgrade before re-enabling this test as it is continuing to flake.

On second thought, I think we should re-enable the suite, but disable the failing test for the time being and re-enable the failing test in #13070.

Kidding. I am closing this PR with the intention of addressing the issues in #13070. Just too many variables to get this reliably fixed.

@rhamilto rhamilto closed this Aug 24, 2023
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-10562. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto deleted the OCPBUGS-10562 branch August 24, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@yanpzhan yanpzhan Awaiting requested review from yanpzhan

@spadgett spadgett Awaiting requested review from spadgett

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhamilto @openshift-ci-robot @jhadvig