CONSOLE-4125,CONSOLE-4294: Replace SelectDeprecated component in user preferences PerspectiveDropdown #14391
Conversation
TheRealJon
commented
Oct 10, 2024
TheRealJon
commented
- Rename PerspectiveDropdown to PreferredPerspectiveSelect
- Refactor PreferredPerspectiveSelect to use supported PF Select component
- Update unit tests to use RTL
…n to PreferredPerspectiveSelect
openshift-ci-robot
added
the
jira/valid-reference
|
@TheRealJon: This pull request references CONSOLE-4125 which is a valid jira issue. This pull request references CONSOLE-4294 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
component/core
| [fireTelemetryEvent, lastViewed, preferredPerspectiveID, setPreferredPerspectiveID], | ||
| ); | ||
|
|
||
| const menuToggle = React.useCallback( |
There was a problem hiding this comment.
Nit: we've been inlining these elsewhere
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Launched cluster against the pr. Regression test to Perspective Dropdown field on user preference page passed. |
openshift-ci
bot
added
the
qe-approved
|
@TheRealJon: This pull request references CONSOLE-4125 which is a valid jira issue. This pull request references CONSOLE-4294 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@TheRealJon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
