CONSOLE-4289: Start a Job from a CronJob #14415
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@cyril-ui-developer: This pull request references CONSOLE-4289 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyril-ui-developer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
kind/cypress
cyril-ui-developer
force-pushed
the
start-job-from-cronjob
branch
from
028ef6c
to
52cf8d4
Compare
|
@cyril-ui-developer: This pull request references CONSOLE-4289 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cyril-ui-developer
force-pushed
the
start-job-from-cronjob
branch
from
52cf8d4
to
e594a41
Compare
|
@cyril-ui-developer: This pull request references CONSOLE-4289 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cyril-ui-developer: This pull request references CONSOLE-4289 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cyril-ui-developer: This pull request references CONSOLE-4289 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cyril-ui-developer: This pull request references CONSOLE-4289 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cyril-ui-developer
force-pushed
the
start-job-from-cronjob
branch
from
e594a41
to
2ce71a0
Compare
cyril-ui-developer
force-pushed
the
start-job-from-cronjob
branch
from
2ce71a0
to
e943cb7
Compare
|
@cyril-ui-developer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| `/k8s/ns/${objNamespace}/jobs/${jobName}`; | ||
|
|
||
| const startJob = (obj: CronJobKind, jobName: string): Promise<JobKind> => { | ||
| const { name, namespace, uid } = obj.metadata; |
| apiVersion: 'batch/v1', | ||
| kind: 'Job', | ||
| metadata: { | ||
| name: jobName, |
There was a problem hiding this comment.
nit, do we need a helper?
| name: jobName, | |
| name: `${name}-${Date.now()}`, |
| cta: () => { | ||
| const jobName = generateJobName(obj.metadata.name); | ||
| startJob(obj, jobName) | ||
| .then(() => { |
There was a problem hiding this comment.
Shoule we use existing helpers to navigate to the job details page?
| .then(() => { | |
| .then((job) => history.push(resourceObjPath(job, JobModel.plural)) |
Screenshots:
Admin console
Dev console
E2E tests