-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-23080: Add multiline support to template instantiation #14416
base: master
Are you sure you want to change the base?
OCPBUGS-23080: Add multiline support to template instantiation #14416
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
09daeb8
to
9faa0d0
Compare
@logonoff I think that's only a part of the cause. Have you checked if the result shows up as a secret? Your recording does not demonstrate looking up the saved value to verify that it's been saved the same. IIRC, When I tried using DevTools to modify that input to a |
It seems to be working fine: |
@logonoff: This pull request references Jira Issue OCPBUGS-23080, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@logonoff: This pull request references Jira Issue OCPBUGS-23080, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@logonoff: This pull request references Jira Issue OCPBUGS-23080, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @vikram-raj for review |
@logonoff: GitHub didn't allow me to request PR reviews from the following users: for, review. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@logonoff: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes:
https://issues.redhat.com/browse/OCPBUGS-23080
#13317
Analysis / Root cause:
<input type="text />
does not support multilineSolution Description:
Add a button to toggle between multiline and single line
Screen shots / Gifs for design review:
Screencast.from.2024-10-18.11-14-55.mp4
Unit test coverage report:
n/a
Test setup:
Download the example template posted in the jira ticket comments and apply it using
oc create -f ./template.yaml
Browser conformance: