Add a section regarding probes, in particular startupProbe #1573
Conversation
|
/cc @TheRealJon @deads2k |
openshift-ci
bot
requested review from
deads2k,
TheRealJon,
Prashanth684 and
tkashem
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| #### Liveness, Readiness, and Startup Probes | ||
| OpenShift should be responsive to pod failure in a timely manner. Thresholds for Liveness and Readiness probes should | ||
| be relatively tight and an unresponsive pod restarted within 30 seconds. If your pods depend on other services or are |
There was a problem hiding this comment.
Unsure whether we think 30 seconds is generally something to guide toward or not.
|
@sdodson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
||
| #### Liveness, Readiness, and Startup Probes | ||
| OpenShift should be responsive to pod failure in a timely manner. Thresholds for Liveness and Readiness probes should | ||
| be relatively tight and an unresponsive pod restarted within 30 seconds. If your pods depend on other services or are |
| themselves slow to start you should leverage a `startupProbe` to allow for that without relying on a high | ||
| `initialDelaySeconds` value on your `livenessProbe` or `readinessProbe`, generally `initialDelaySeconds` should not | ||
| be significantly higher than `periodSeconds`. See upstream [Probe | ||
| documentation](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/). |
There was a problem hiding this comment.
We've seen resource consumption issues using exec probes in SNO deployments. Can we specify that we want HTTP probes (or at least not exec probes) as part of this update?
|
Inactive enhancement proposals go stale after 28d of inactivity. See https:/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale enhancement proposals rot after 7d of inactivity. See https:/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten enhancement proposals close after 7d of inactivity. See https:/openshift/enhancements#life-cycle for details. Reopen the proposal by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
(automated message) This pull request is closed with lifecycle/rotten. It does not appear to be linked to a valid Jira ticket. Should the PR be reopened, updated, and merged? If not, removing the lifecycle/rotten label will tell this bot to ignore it in the future. |
2 similar comments
|
(automated message) This pull request is closed with lifecycle/rotten. It does not appear to be linked to a valid Jira ticket. Should the PR be reopened, updated, and merged? If not, removing the lifecycle/rotten label will tell this bot to ignore it in the future. |
|
(automated message) This pull request is closed with lifecycle/rotten. It does not appear to be linked to a valid Jira ticket. Should the PR be reopened, updated, and merged? If not, removing the lifecycle/rotten label will tell this bot to ignore it in the future. |
No description provided.