NE-705: IngressController subnet selection in AWS #1595
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@gcs278: This pull request references NE-705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.13" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
8a2586a
to
8bc4b3d
Compare
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
2 times, most recently
from
8dbb992
to
1a5f6b7
Compare
|
@gcs278: This pull request references NE-705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.13" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gcs278
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Ready for initial review, but will keep hold on until I feel it has consensus. Currently missing install-time design, but I have stubbed out the sections that need updating for that. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@gcs278: This pull request references NE-705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.13" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
1a5f6b7
to
565156e
Compare
|
Updating the Enhancement for the API to be immutable. Temporarily WIP |
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
565156e
to
51a7c4d
Compare
|
/wip cancel |
|
/assign |
|
@candita Updated to reflect Joel API design suggestion for openshift/api#1841. May update a few more times to keep enhancement and API in sync. |
|
/lgtm |
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
5132daf
to
c69aee5
Compare
|
@candita Sorry, another update to keep in sync with the API: https:/openshift/enhancements/compare/5132daf966f01988aec29c9202b505c8aaf32aef..c69aee540871a86f6209bd35701af85e7b654dd5 Joel has LGTM'ed the API PR now. |
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
c69aee5
to
354c494
Compare
|
@candita synced up with the API PR openshift/api#1841 Mind LGTM'ing again when you get a chance? |
|
/lgtm |
|
Just had another look - LGTM. /approve @Miciah: unhold if it's fine with you. |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
There is interest in refactoring Subnets from the higher-level AWSLoadBalancerParameters to more specific AWSClassicLoadBalancerParameters to AWSNetworkLoadBalancerParameters for better handling of future additions of new types of LBs. |
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
354c494
to
2c21de1
Compare
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
2c21de1
to
a6324dd
Compare
Adds lb-subnet-selection-aws.md enhancement for specifying IngressController's load balancer type service subnets.
Add ingress.operator.openshift.io/auto-delete-load-balancer functionality to the lb-subnet-selection-aws.md enhancement. This allows for configuration management tooling to seamlessly update subnets on an IngressController.
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
9cf1881
to
8f60569
Compare
|
The enhancement should now reflect the API updates of per-LB-type subnets. I just forgot to take the hold off. Note that the implementation for the Epic https://issues.redhat.com/browse/NE-705 is merged. |
openshift-ci
bot
removed
the
do-not-merge/hold
Add details to the `LoadBalancer Subnet Selection for AWS` proposal explaining how changing the load balancer type affects the subnets.
gcs278
force-pushed
the
ingresscontroller-subnets-aws
branch
from
8f60569
to
aa35db2
Compare
|
/lgtm |
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Adds lb-subnet-selection-aws.md enhancement for specifying IngressController's load balancer type service subnets. This enhancement introduces
spec.endpointPublishingStrategy.loadBalancer.providerParameters.aws.classicLoadBalancer.subnetsandspec.endpointPublishingStrategy.loadBalancer.providerParameters.aws.networkLoadBalancer.subnetswhich allows cluster admins to specify the subnets for the load balancer.Epic: https://issues.redhat.com/browse/NE-705
RFE: https://issues.redhat.com/browse/RFE-1717