-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create operator-sdk
update guidelines
#1540
Comments
This is a blind patch albeit still better than before. The full steps for each new operator-sdk upgrade is already outlined in docs at https://sdk.operatorframework.io/docs/upgrading-sdk-version/ The intent by operator-sdk authors per my understanding is for you to follow every step there. For example, when upgrading to https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.34.0/ you are expected to make changes to your makefile. |
Problem
Currently, we do not have any strategy to update
operator-sdk
version used by the project. Last time we updated it, for example, was to fix problem fixed in newer releases. Reference #1398But we only updated the executable version, without any updates to project structure, which can cause
operator-sdk
commands and functionalities not work properly.Currently, some of
operator-sdk
functionalities are broken in the project.Example
These lines are wrong, pointing to an object that does not exist (
buckets.oadp.openshift.io
)oadp-operator/controllers/bucket_controller.go
Lines 44 to 47 in 5b0b9fc
If we update it and run
make bundle
,config/rbac/role.yaml
is not updated.oadp-operator/config/rbac/role.yaml
Line 51 in 5b0b9fc
Solution
As proposed previously in #1250 and already being applied in NAC project (references https:/migtools/oadp-non-admin/blob/master/docs/CONTRIBUTING.md#upgrade-kubebuilder-version https:/migtools/oadp-non-admin/blob/master/docs/architecture.md#kubebuilde), we should update all necessary places when updating
operator-sdk
version.To avoid human mistakes of forgetting to apply a change describe in
operator-sdk
documentation, we should do this update following these instructions:Download both current and new version of
operator-sdk
from https:/operator-framework/operator-sdk/releases and runPros
operator-sdk
commands or functionalitiesdocker
andpodman
in Makefile)oadp-operator/bundle/tests/scorecard/config.yaml
Line 11 in 5b0b9fc
Cons
The text was updated successfully, but these errors were encountered: