Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Velero to support restic restores of pods managed by DeploymentConfigs #340

Closed
dymurray opened this issue Sep 27, 2021 · 5 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@dymurray
Copy link
Member

dymurray commented Sep 27, 2021

There has been a longstanding upstream issue with taking restic backups/restores of volumes which are mounted via pods that are owned by DeploymentConfigs. What ends up happening is at restore time, Velero restores the pod that mounts the volume and the DeploymentConfig which manages the pod.

This causes problems as the deploymentconfig adopts the restored pod, and redeploys a new version while terminating the old one. This is a problem because the restored pod contains the initContainer which waits for the restic restore to complete. Without this pod running with the initContainer, the restic restore process fails.

Related issues:
vmware-tanzu/velero#2073
vmware-tanzu/velero#1981

If we decide that we cannot change the upstream code to support this, then we will want to at a minimum document the process of creating 2 restores (first restore just pods+pvcs, second restore everything else) to workaround this.

@dymurray dymurray added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 28, 2021
@dymurray
Copy link
Member Author

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 12, 2022
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed May 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2022

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants