Add Wesley sample unit tests to buildVeleroDeployment #1390
Conversation
Signed-off-by: Tiger Kaovilai <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| dpa: func() *oadpv1alpha1.DataProtectionApplication { | ||
| dpa := &oadpv1alpha1.DataProtectionApplication{} | ||
| err := yaml.Unmarshal([]byte(`apiVersion: oadp.openshift.io/v1alpha1 | ||
| kind: DataProtectionApplication |
There was a problem hiding this comment.
can Go struct be used instead of string literal ❓
There was a problem hiding this comment.
I was just too lazy to covert. I think I'll close it later
|
reopened for discussion at scrum if we want to allow user yamls or convert everything to go. |
|
@kaovilai: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
do-not-merge/hold
Signed-off-by: Tiger Kaovilai [email protected]