Add Design for Upload Speed Test with BSL Config for Object Storage #1558
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| - Uses appropriate cloud SDKs (AWS, Azure, or GCP) to perform uploads. | ||
| - Updates the status of UST CR with upload speed, upload success/failure and error message if any. | ||
| - OADP/DPA-UST Integration: | ||
| - Fetches BackupStorageLocation (BSL) details from the OADP operator’s DPA CR. |
There was a problem hiding this comment.
if a customer has multiple bsl's configured in the dpa will it go through each?
There was a problem hiding this comment.
yes its per BSL configured in the DPA, we are adding a uploadSpeedTest struct, please refer the proposed CRD section and DPA spec changes section.
| config: | ||
| region: us-east-1 | ||
| bucket: my-backup-bucket | ||
| uploadSpeedTest: |
There was a problem hiding this comment.
If we're not going to support automatic speed checks, I'm confused why the DPA needs to change initially.
There was a problem hiding this comment.
Auto-Check or not depends on the user configuration here. For each BSL configured we have a uploadSpeedTest struct that has enabled flag and uploadSpeedTest config. If the user sets these then UST CR would be automatically created by OADP Operator for that particular BSL, else the user could create the UST CR themselves.
| Proposed Upload Speed Test CRD: | ||
|
|
||
| ```yaml | ||
| apiVersion: uploadspeedtest.io/v1alpha1 |
There was a problem hiding this comment.
why not oadp.openshift.io? or velero.io?
Make this not dependent on dpa?
There was a problem hiding this comment.
yeah need to update that to oadp.openshift.io
Why the changes were made
How to test the changes made