-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staged upstream repositories #2
Conversation
/test all |
/test all |
/lgtm |
/approve |
/lgtm cancel |
Oh weird it's probably reading from the OWNERS file that attached to the commit and not this repository's current OWNERS file. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/verify-owners |
New changes are detected. LGTM label has been removed. |
/verify-owners |
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing
|
staging/api/OWNERS
Outdated
# approval == this is a good idea /approve | ||
approvers: | ||
- ecordell | ||
- njhale | ||
- dinhxuanvu | ||
- kevinrizza | ||
- benluddy | ||
# review == this code is good /lgtm | ||
reviewers: | ||
- ecordell | ||
- njhale | ||
- dinhxuanvu | ||
- kevinrizza | ||
- gallettilance | ||
- anik120 | ||
- exdx | ||
- awgreene | ||
- Bowenislandsong | ||
- benluddy | ||
- ankitathomas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this file
|
||
# approval == this is a good idea /approve | ||
approvers: | ||
- ecordell | ||
- njhale | ||
- kevinrizza | ||
- benluddy | ||
- awgreene | ||
# review == this code is good /lgtm | ||
reviewers: | ||
- ecordell | ||
- njhale | ||
- kevinrizza | ||
- benluddy | ||
- dinhxuanvu | ||
- gallettilance | ||
- anik120 | ||
- exdx | ||
- awgreene | ||
- hasbro17 | ||
- ankitathomas | ||
- joelanford | ||
- timflannagan | ||
# Bugzilla component | ||
component: "OLM" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Superseded by #5 /close |
@timflannagan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Package cleanup (upstream operator-registry commit: 06f1c06ac03372aa94253fdf6f8fdbb59dfa3a5c)
This is the 1st commit message: wip This is the commit message openshift#2:
This is the 1st commit message: wip This is the commit message openshift#2:
This is the 1st commit message: wip This is the commit message openshift#2:
This is the 1st commit message: wip This is the commit message openshift#2:
This is the 1st commit message: wip This is the commit message openshift#2:
This is the 1st commit message: wip This is the commit message openshift#2:
This is the 1st commit message: wip This is the commit message openshift#2:
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]>
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
* refactor to move more processing to the template Signed-off-by: Jordan Keister <[email protected]> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <[email protected]> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * caching wip Signed-off-by: Jordan Keister <[email protected]> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <[email protected]> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <[email protected]> --------- Signed-off-by: Bryce Palmer <[email protected]> Signed-off-by: Jordan Keister <[email protected]> * whitespace sanity hell Signed-off-by: Jordan Keister <[email protected]> * drop STDERR for nominal case Signed-off-by: Jordan Keister <[email protected]> --------- Signed-off-by: Jordan Keister <[email protected]> Signed-off-by: Catherine Chan-Tse <[email protected]> Signed-off-by: Bryce Palmer <[email protected]> Co-authored-by: Catherine Chan-Tse <[email protected]> Co-authored-by: Bryce Palmer <[email protected]> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546
… to a file-based catalog (#1127) * Documentation on how to add a plain bundle to a file-based catalog Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback Signed-off-by: Rashmi Gottipati <[email protected]> * Clarify regular bundle to be of registry+v1 format Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback openshift#1 Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback openshift#2 Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback openshift#3 Signed-off-by: Rashmi Gottipati <[email protected]> * Add an example for the desired channel name and link to OLM best practices for channel naming conventions Signed-off-by: Rashmi Gottipati <[email protected]> --------- Signed-off-by: Rashmi Gottipati <[email protected]>
… to a file-based catalog (#1127) * Documentation on how to add a plain bundle to a file-based catalog Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback Signed-off-by: Rashmi Gottipati <[email protected]> * Clarify regular bundle to be of registry+v1 format Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback openshift#1 Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback openshift#2 Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback openshift#3 Signed-off-by: Rashmi Gottipati <[email protected]> * Add an example for the desired channel name and link to OLM best practices for channel naming conventions Signed-off-by: Rashmi Gottipati <[email protected]> --------- Signed-off-by: Rashmi Gottipati <[email protected]> Upstream-repository: operator-registry Upstream-commit: bca2bfb89bc4db7bd9ebd08031be3d59bfdc65e8
No description provided.