fix skip tests #365
Merged
fix skip tests #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Demeester <[email protected]> (cherry picked from commit d728e50) Signed-off-by: Nikhil Thomas <[email protected]>
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas, piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pradeepitm12
pushed a commit
that referenced
this pull request
Jan 27, 2021
We were previously using a regex to extract expressions within TriggerBindings. The regex only extracted between the initial `$(` and the first occurrence of the `)`. This meant that some valid JSONPath expressions that contained brackets (e.g. filters) were incorrectly extracted. This commit fixes the issue by splitting the string on `$(` and then extracting until the first "unbalanced" occurrence of `)`. Fixes #365 Co-Authored-By: Andrea Frittoli <[email protected]> Signed-off-by: Dibyo Mukherjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies openshift/e2e-tests-openshift.sh with appropriate flags to skip RootUser Tests
Related to: tektoncd#2304
and #364
changes in tektoncd#2304 will not be available in upstream rc3, hence it is separately added in midstream rc3 branch through #364
Signed-off-by: Vincent Demeester [email protected]
(cherry picked from commit d728e50)
Signed-off-by: Nikhil Thomas [email protected]