Skip to content

Commit

Permalink
tests: Use valid IPv6 address
Browse files Browse the repository at this point in the history
Python 3.11.4 [1] includes a fix for gh-103848 [2] and
urllib.parse.urlsplit will now validate that bracketed IP addresses are
valid IPv6 address. Fix this.

[1] https://docs.python.org/release/3.11.4/whatsnew/changelog.html#python-3-11-4
[2] python/cpython#103848

Change-Id: Ibd3d24e07f0c5670224b3e186b329c207666a2ab
Signed-off-by: Stephen Finucane <[email protected]>
  • Loading branch information
stephenfin committed Jul 14, 2023
1 parent b18848b commit 171580c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions taskflow/tests/unit/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@ def test_port_provided(self):
self.assertEqual('', parsed.path)

def test_ipv6_host(self):
url = "rsync://[2001:db8:0:1]:873"
url = "rsync://[2001:db8:0:1::2]:873"
parsed = misc.parse_uri(url)
self.assertEqual('rsync', parsed.scheme)
self.assertEqual('2001:db8:0:1', parsed.hostname)
self.assertEqual('2001:db8:0:1::2', parsed.hostname)
self.assertEqual(873, parsed.port)

def test_user_password(self):
Expand Down

0 comments on commit 171580c

Please sign in to comment.