Budge gateway closer to ready-to-trace #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 23, 2020 10:18
```plain $ mix local.hex --force * creating .../hex-0.20.5 $ mix deps.get Resolving Hex dependencies... Dependency resolution completed: Unchanged: ... everything All dependencies are up to date ```
garthk
force-pushed
the
fix-dependencies
branch
2 times, most recently
from
824b2f0
to
dfd3ea9
Compare
added 3 commits
May 23, 2020 19:45
Forced by `opentelemetry_plug`. Detective work to find out which OTP the Docker image is packing so we can match it for those using `asdf` on macOS for performance reasons: ```plain $ docker pull elixir:1.10.3-alpine ... $ docker history --no-trunc elixir:1.10.3-alpine | egrep -oE 'OTP\W+=\S+' OTP_VERSION=22.3.4 $ curl -s http://erlang.org/download/ | grep 22.3.4 | sed -e 's/<[a-zA-Z\/][^>]*>//g' OTP-22.3.4.1.README 20-May-2020 10:31 4465 OTP-22.3.4.README 08-May-2020 11:29 3307 ``` Yell if you'd prefer 22.3.4.1.
Prepares for test configuration and, with it, tests.
This is overkill for now, but will become necessary to prove we've got everything wired up properly to forward trace context in HTTP headers.
|
Oh I see, #2 is here now. Can #2 be closed to not cause confusion :) @GregMefford did you want to take a look at this? |
|
@GregMefford ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GregMefford I've started splitting out chunks from #2 as requested. I'm deliberately stopping just before adding the trace headers and testing the same, per our discussion about careful commit order on the trunk. I've also kept each step simpler than in #2.